-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LinkedIn Logo #6932
fix: LinkedIn Logo #6932
Conversation
Signed-off-by: Jay <jay.sanjay.karia@gmail.com>
fix: LinkedIn logo
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Jay <jay.sanjay.karia@gmail.com>
Signed-off-by: Jay <jay.sanjay.karia@gmail.com>
Unit Test Coverage ReportUnit Test Report
|
IMO, the error we got in Build should be solved with #6933. Could you rebase please @Jay-Karia 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution
I didn't understand all of LinkedIn's trademark policy, but shouldn't the logo always be in blue? |
Should we merge this ?? 🙃 |
Why not but we need to answer to my questions |
Right the logo should be blue, not black. |
Can't we use the monochrome version(Black, Reversed white) of the LinkedIn logo? When I look at the contrast ratio ( I think it would be better to use monochrome versions as we can provide a better contrast ratio 👀 What do you think @ovflowd @AugustinMauroy |
Are those official/allowed LinkedIn contrast schemas? We can't change the logo... If yes, then let's proceed with it. |
from the official LinkedIn branding policy |
When I look at the document, there are black and reversed white versions; And the branding assets created for China also have black and reversed white versions. When I look at the available documents, I see only the white version. I think the safest way would be to go with the blue one and update it when we find a better version in the future 😞 |
Can we go for Trademark request ? (if possible) |
a black / white logo is common practice and explicitly called out - we are overthinking it if we think we must use only blue
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AS-IS - this have my approval
merging this - it's adherent to my reading of the policy - no longer in a circle, and the color scheme is correct for light/dark use cases |
Description
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.Closes #6928